-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: no iframe, use swagger-ui component #36
feat: no iframe, use swagger-ui component #36
Conversation
smarinier
commented
Nov 5, 2024
- remove iframe use and references
- remove stoplight from packages
- add swagger-ui package
- use SwaggerUI Vue
Signed-off-by: Sebastien Marinier <[email protected]>
Thanks, this is a much smaller change than I expected. |
I prefer to separate subjects with PRs. I find this make it more readable, and the commit in history get a chance to be significant. So I planned to make another PR for the side bar subject. Same for the darkmode. It was not done in my app, so i have to work specifically on it. It's not very complicated, as somebody built a SwaggerDark.css. I remove the view route. |
Signed-off-by: Sebastien Marinier <[email protected]>
Can you do that in this PR please? |
Signed-off-by: Sebastien Marinier <[email protected]>
The dark theme is not working for me, I believe the CSS selector is not matching anything? |
The CSS selector is based on [data-theme-dark], that should be set in your tag (?) OK. I change for *=dark |
Signed-off-by: Sebastien Marinier <[email protected]>
It's still not working for me because it is set to |
I'm not use to handle the dark mode. I took selectors that are used in Nextcloud vue components Maybe you should check how you can select a dark theme without having data-themes correctly set ? |
I figured out what the problem is: |
In that case, you probably found a nextcloud bug. |
I'm not sure, it seems they work just fine? |
Considering data-themes is not set in your case, i guess this won't work, by example: // Add extra border for high contrast mode |
As far as I can tell everything is correct. The fact that data-themes can also be an empty string is a bug in the server which I just fixed: nextcloud/server#49112 |
Signed-off-by: provokateurin <[email protected]>
I know duplicating the styles is a bit ugly, but it works and there is no easy workaround to the problem that you can not combine media queries and selectors. |
I think we could avoid the source duplication with sass, but indeed I'm not sure there's a simple way to avoid the double CSS. |
Sure, would you be able to set that up and change it? I never used it so far...
No I think this good now! |
Signed-off-by: Sebastien Marinier <[email protected]>
Done! This let me know that the CSS nesting i was using is quite recent with browsers, so this is better, even if the result looks very repetitive. |
Signed-off-by: Sebastien Marinier <[email protected]>
Signed-off-by: Sebastien Marinier <[email protected]>
Awesome now it works as expected, except for the server bug 👍 |
I'll make a new release next week |
I'm working on the menu and the routes (#34). |
Ah ok, then I will wait for those :) |