Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use vars for repeated calls #2188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: use vars for repeated calls #2188

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Feb 11, 2025 •
edited
Loading

Small optimization, no functional changes.

@solracsf solracsf added this to the Nextcloud 32 milestone Feb 11, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@solracsf
Copy link
Member Author

Query count bot is outdated.

nickvergessen
nickvergessen reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a huge diff there is nothing gained and it will break backports if needed, so I'm hesitant

lib/MailNotifications.php Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8909 was 8700 (+2.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
2 participants
@solracsf @nickvergessen