Load attachments from v1.4 attachment api #159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-ver
force-pushed
the
load_attachments
branch
2 times, most recently
from
c7d3f8d to
13a1ca9
Compare
Collaborator
|
Hi @oli-ver is this PR still in progress? |
Author
|
Hello @mpivchev, yes but I will not have time to work on it for the next 2 weeks. It is in part working, still trying to figure out why file names with characters that need to be html encoded do not work. |
Load attachments from the v1.4 attachment API Store attachments Signed-off-by: oli-ver <[email protected]>
oli-ver
force-pushed
the
load_attachments
branch
from
13a1ca9 to
fa069e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load attachments from the v1.4 attachment API
Store attachments
Covers the first part of the "show images" requirement in #68 : Load the images and store them
Visualization not yet implemented