Feature/update screenshots #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
feature/update-screenshots
branch
2 times, most recently
from
e9d59a7 to
1d9ea18
Compare
Member
Author
|
Found #541 in the screenshots, waiting for it to be merged |
Leptopoda
reviewed
Aug 11, 2023
Member
There was a problem hiding this comment.
Can we do this in a different way?
I don't like the hacks needed to make keys work.
Maybe finding it by the label (text)? This might get harder if we want to make multiple screenshots for the app stores (in different languages) but it would at least keep the app code cleaner
Member
Author
|
I was using the keys before, but searching for the labels makes so much more sense! I'll implement it that way |
Member
Author
No we can just use the AppLocalizations and search for the text we get from there. Then it doesn't matter which language the text actually has |
provokateurin
force-pushed
the
feature/update-screenshots
branch
from
1d9ea18 to
384fc5f
Compare
Leptopoda
reviewed
Aug 27, 2023
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
feature/update-screenshots
branch
from
384fc5f to
7f58fa8
Compare
Leptopoda
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.