Feature/litmus tests #513
Merged
Feature/litmus tests #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
feature/litmus-tests
branch
2 times, most recently
from
a2a5055 to
d32084f
Compare
This was referenced Jul 30, 2023
provokateurin
force-pushed
the
feature/litmus-tests
branch
from
d32084f to
c8f01a9
Compare
Leptopoda
reviewed
Aug 2, 2023
Member
Leptopoda
left a comment
Leptopoda
left a comment
There was a problem hiding this comment.
I'm not a WebDAV expert by any means but other than the cosmetic changes it looks reasonable.
provokateurin
force-pushed
the
feature/litmus-tests
branch
from
c8f01a9 to
b2e14b7
Compare
Leptopoda
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#435
Implements most of the applicable tests from https://github.com/notroj/litmus.
Sadly the tests are not as extensive as I had hoped. Some of the existing tests have to stay. Though it helped to uncover some problems with litmus and the Nextcloud implementation and also in our client code.