perf(quick-actions): eliminate duplicate api calls for each envelope #11945
Conversation
hamza221
changed the title
hamza221
force-pushed
the
perf/quick-actions
branch
from
8be1b55 to
c94ffa6
Compare
hamza221
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Ci needs some tweaking |
Signed-off-by: Hamza <[email protected]>
hamza221
force-pushed
the
perf/quick-actions
branch
from
c94ffa6 to
94959ca
Compare
| } else { | ||
| this.localAction = { ...action } | ||
| this.actions = await findAllStepsForAction(action.id) | ||
| this.localAction = { id: action.id, name: action.name, accountId: action.accountId } |
There was a problem hiding this comment.
is there no generic way to clone an object in vue? the manual destruct/construct is fragile. when we change properties of the object we have to keep this line in sync.
There was a problem hiding this comment.
we need specific properties from the Object
There was a problem hiding this comment.
can you elaborate? what I see above we map three properties to identical properties.
There was a problem hiding this comment.
Sorry, I meant the object contains both quickActions and action steps to avoid multiple requests to the servers
so it looks like {id, name, accountId, actionsSteps : [array of steps] }
I split them back here so I don't break the CRUD logic for both
If you look at the next line you will see that I'm also storing the steps in a local variable.
There was a problem hiding this comment.
Right. But what I'm objecting to is that you are manually writing down the properties to copy to the local action. If a new property is added to it, you have to also update the code here. It's prone to errors.
I like the old approach better where you used the generic object destruct to take all properties of the action object.
fix #11746