fix: apostrophe issue #10614
Merged
fix: apostrophe issue #10614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
src/components/NoMessageSelected.vue
Outdated
| @@ -37,7 +37,7 @@ export default { | |||
|
|
|||
| computed: { | |||
| welcomeMessage() { | |||
| return t('mail', 'Welcome to {cloudName} Mail', { cloudName: window?.OC?.theme?.name ?? 'Nextcloud' }) | |||
| return t('mail', 'Welcome to {cloudName} Mail', { cloudName: window?.OC?.theme?.name ?? 'Nextcloud' }, null, {escape: false}) | |||
There was a problem hiding this comment.
mail/src/components/NoMessageSelected.vue
Lines 13 to 15 in ae4502a
welcomeMessage into the DOM as-is. Doesn't that open the door for code injection?Is
window?.OC?.theme?.name HTML encoded already?!
There was a problem hiding this comment.
window?.OC?.theme?.name is not HTML encoded, the encoding happens in the translation function.
Made changes, what do you think?
ChristophWurst
approved these changes
Jan 30, 2025
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/noid-apostrophe
branch
from
3ad4681 to
032a0bf
Compare
|
/backport to stable4.2 |
|
/backport to stable3.7 |
2 tasks
|
/backport to stable4.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10534
Fixes and issue with apostrophes in system name