Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(message-summary): respect admin config #10610

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix(message-summary): respect admin config #10610

merged 1 commit into from
Jan 28, 2025

Conversation

hamza221
Copy link
Contributor

summarizeMessagesfeature is enabled by default, and not checking the admin config #10465 (comment)

@hamza221 hamza221 self-assigned this Jan 27, 2025
@SebastianKrupinski
Copy link
Contributor

The check should be happening on this line,

mail/lib/Service/AiIntegrations/AiIntegrationsService.php

Line 70 in 1c46bab

$this->taskProcessingManager->getPreferredProvider(TextToTextSummary::ID);

What issue is it causing?

@hamza221
Copy link
Contributor Author

hamza221 commented Jan 27, 2025 •
edited
Loading

mail/lib/Service/AiIntegrations/AiIntegrationsService.php

There's a separate admin config for groupware

@SebastianKrupinski
Copy link
Contributor

mail/lib/Service/AiIntegrations/AiIntegrationsService.php

There's a separate admin config for groupware

Ah. Was not aware of this.

@hamza221 hamza221 force-pushed the fix/message-summary branch from 910043b to 84d9398 Compare January 27, 2025 15:44
@hamza221
Copy link
Contributor Author

/backport to stable4.2

@hamza221 hamza221 force-pushed the fix/message-summary branch from 84d9398 to 8b127ae Compare January 27, 2025 16:05
@hamza221 hamza221 force-pushed the fix/message-summary branch from 8b127ae to 95475ac Compare January 28, 2025 09:30
ChristophWurst
ChristophWurst reviewed Jan 28, 2025
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This is a change that's easy to unit-test. Would you mind covering this condition with at least one test?

@hamza221 hamza221 force-pushed the fix/message-summary branch from 95475ac to 75ac055 Compare January 28, 2025 10:20
@hamza221 hamza221 requested a review from GretaD as a code owner January 28, 2025 10:20
@hamza221 hamza221 force-pushed the fix/message-summary branch from 75ac055 to a7434c4 Compare January 28, 2025 10:22
@hamza221 hamza221 enabled auto-merge January 28, 2025 10:32
@hamza221 hamza221 merged commit 2c246fb into main Jan 28, 2025
35 checks passed
@hamza221 hamza221 deleted the fix/message-summary branch January 28, 2025 10:33
@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianKrupinski SebastianKrupinski SebastianKrupinski approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Assignees

@hamza221 hamza221

Labels
3. to review bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza221 @SebastianKrupinski @ChristophWurst