Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update roster when creating, deleting and changing users #33

Merged
merged 8 commits into from
Jul 19, 2017
Merged

Update roster when creating, deleting and changing users #33

merged 8 commits into from
Jul 19, 2017

Conversation

LEDfan
Copy link
Member

@LEDfan LEDfan commented Jul 8, 2017

This updates the roster of all clients when a user is created, deleted or updated.

Fixes jsxc/jsxc#565

@LEDfan
Copy link
Member Author

LEDfan commented Jul 8, 2017

This also fixes an avatar loading issue.

@LEDfan LEDfan changed the title Update roster when creating, deleting and chaning users Update roster when creating, deleting and changing users Jul 8, 2017
@LEDfan LEDfan mentioned this pull request Jul 8, 2017
Closed
@LEDfan
Copy link
Member Author

LEDfan commented Jul 14, 2017 •
edited
Loading

TODO:

  • also send a stanza to remove deleted uses (using the addressbookchanges table)
  • execute the refresh on app install/enable using install.php
  • rebase

@LEDfan
Copy link
Member Author

LEDfan commented Jul 14, 2017

The filenames must be in lowercase to support Nextcloud 9 (I think it works in >9 because of some PSR4 implementing in core), but indeed the classes should be CamelCase. Sometimes an IDE does too much, thanks for catching 👍

@sualko sualko modified the milestone: 3.3.0 Jul 14, 2017
LEDfan added 7 commits July 15, 2017 09:11
@LEDfan
Change roster items when user is created, deleted or changed
aee806c
@LEDfan
Fix loading of avatars
1202581
@LEDfan
Delete information stored about a user when deleting or disbaling thi…
52ac44a 
…s user
@LEDfan
Fix side effects of running updatePresence in the constructor of Pres…
7bf7072 
…enceMapper
@LEDfan
Add command to refresh roster of all users
00b268b
@LEDfan
Make filenames lowercase for stable9
1f35830
@LEDfan
When storing stanzas in the database always use the lowercase UserId
0a0c6ce 
fixes #35.

There are two problems:
 - NC accepts to login with a username which has a different casing than
   the username in the DB.
 - the front-end sends "to" usernames as lowercase

The solution is to convert the username of the current logged in user to
lowercase and always use lowercase usernames in the DB.

Signed-off-by: Tobia De Koninck <[email protected]>
@LEDfan
Copy link
Member Author

LEDfan commented Jul 15, 2017

ojsxc-3.2.1.tar.gz

@LEDfan LEDfan mentioned this pull request Jul 15, 2017
Closed
@sualko
Copy link
Member

sualko commented Jul 17, 2017

I can confirm the message delivery bug and also that the fix is working. 👍 Good job @LEDfan and great catch @Schmuuu.

@Schmuuu
Copy link

Schmuuu commented Jul 17, 2017

Hi @sualko

Thanks a lot! I'm very glad I could help somehow.
I can also confirm the fix is working. Great Job @LEDfan !

@sualko
Copy link
Member

sualko commented Jul 18, 2017

@LEDfan I would like to make a new (beta) release in the next few days. Do you think we can merge or do you need more time?

@LEDfan
Copy link
Member Author

LEDfan commented Jul 18, 2017

@sualko it's okay for me to merge this, I'll do the TODO's in a follow-up PR then (they are only some race conditions)

@sualko sualko merged commit 6255934 into master Jul 19, 2017
@sualko sualko deleted the fix_new_users branch July 19, 2017 11:36
@sualko
Copy link
Member

sualko commented Jul 19, 2017

@LEDfan do they need to go into the beta release?

@LEDfan
Copy link
Member Author

LEDfan commented Jul 20, 2017

@sualko I'll probably work on it tomorrow or Saturday, but I don't think they need to go into the beta.

@Nils160988
Copy link

I am not sure if I have to create a new issue or post it somewhere else, but there seems to be a regression after the update of the app to version 3.3.0.

After the update to 3.3.0 the old problems showed up again.
Everything seems to work with the zip provided here after manual downgrading.

@sualko
Copy link
Member

sualko commented Sep 20, 2017

@Nils160988 please open an new issue, so we can keep track of it.

@Nils160988 Nils160988 mentioned this pull request Sep 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LEDfan @sualko @Schmuuu @Nils160988