-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support moving versions across storages #2860
Support moving versions across storages #2860
Conversation
b009ced
to
7ae2223
Compare
5bb731e
to
411607e
Compare
59fb534
to
a09fa85
Compare
c2a8c68
to
006022a
Compare
a0e5d8f
to
fed1b23
Compare
fed1b23
to
90d7c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was moving from one groupfolders to another also tested?
And moving from groupfolder to folder?
Out of the scope of this PR. This is only tackling folder to groupfolder move, and vis versa.
Yes, both way. |
90d7c85
to
29a63be
Compare
Signed-off-by: Louis Chemineau <[email protected]>
29a63be
to
8e74fd6
Compare
/backport to stable29 |
@artonge There is a typing problem it seems? |
As of nextcloud/server#44187
One limitation is that when copying a folder from and to a groupfolder, versions of subfolders will be lost. This is due to the
NodeCopiedEvent
event not containing the list of moved files in subfolders. This needs to be addressed in the server.Example: When moving
/a
containing/a/b/c.txt
into/d
which is a groupfolder, thenc.txt
will lose its versions because theNodeCopiedEvent
does not contain the information thatc.txt
was copied. Weirdly, it works when moving a folder containing/a/c.txt
.The test exists and is disabled for now.