-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save a Single Question as csv #1408
base: main
Are you sure you want to change the base?
Conversation
3711289
to
0428dc9
Compare
0428dc9
to
542a885
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1408 +/- ##
============================================
- Coverage 43.96% 35.58% -8.38%
+ Complexity 646 523 -123
============================================
Files 58 49 -9
Lines 2550 2043 -507
============================================
- Hits 1121 727 -394
+ Misses 1429 1316 -113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only 1 nitpick: When you download the question CSV of multiple questions, it’s not really possible to distinguish, not even from a full responses download. Instead of the current
Formname (responses).csv
What would be nicer for the individual questions is:
Formname (responses - questionname).csv
I guess the question name has to be stripped of some special characters as well – just like we do for Formname I assume.
And also as discussed, we should probably remove the (responses) part from the export file cause it can mess with import and translations. cc @Chartman123 @jotoeri |
Can you also add tests? Codecov is unhappy. |
Ok - sorry for kicking in here with a bad comment, but that should probably be discussed before putting too much more work into this: (An export of the single questions summary-graphics would e.g. be a different thing! Then one could see the benefit of quickly having a human-readable representation of the summary.) |
I fully agree from the technical perspective with you @jotoeri to keep things simple. However, NC was recently started to be used extensively as a complete backoffice solution for no-code office process management. This is very good news, because this means that it can completely replace the other, proprietary online offices, but it also means that some functionality cannot be simple unfortunately. The controlled data collection, surveying inside a company via Forms is also a crucial feature in other office solutions. So unfortunately, this contradicts with your "simple forms" vision. |
@gerazo note that right now this pull request implements the export of a single Question and its answers. But I think what you are referring to is the exporting of a single Response, correct? @hamza221 and I talked about it and yeah, it does make sense. @jotoeri @Chartman123 what do you think? That is, having export in both the Summary and the Responses view on individual questions and responses.
|
a7d6184
to
88f6dd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments. Please add the new API endpoints to the documentation, too :)
And currently one can only download the CSV file. I think it would be nice to be able to save it to the cloud just like for all submissions.
0917573
to
b56b7eb
Compare
Signed-off-by: hamza221 <[email protected]>
b56b7eb
to
bde8b86
Compare
Signed-off-by: hamza221 [email protected]