fix(JWTManager): Mark private key as sensitive #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
nickvergessen
requested review from
julien-nc
and removed request for
nickvergessen
julien-nc
reviewed
Oct 14, 2024
| @@ -44,6 +44,7 @@ More information is available in the External sites documentation.]]></descripti | |||
| <repair-steps> | |||
| <post-migration> | |||
| <step>OCA\External\Migration\CopyDefaultIcons</step> | |||
| <step>OCA\External\Migration\JWTTokenPrivateKeySensitive</step> | |||
There was a problem hiding this comment.
So you're going to run this on each upgrade. Don't you wanna run it only once?
I did that in a migration step in a bunch of apps.
There was a problem hiding this comment.
Abusing the database migrations to do this feels wrong to me.
Executing this repair step is extremely cheap, so I think this is fine.
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
julien-nc
approved these changes
Oct 21, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.