Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mention of legacy filelocking.enabled toggle #11848

Merged
merged 1 commit into from
May 24, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 21, 2024

No longer relevant today since it's not an experimental feature (hasn't been for nearly a decade) and is now on by default. There is no good reason to disable it. The toggle only exists to be able to enable it, when it was still experimental.

See nextcloud/server#45330 & nextcloud/server#45330 (comment) + nextcloud/server#45471

☑️ Resolves

🖼️ Screenshots

image

No longer relevant today since it's not an experiment feature and is now on by default. There is no good reason to disable it.

See #45330 & nextcloud/server#45330 (comment)

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 23, 2024
@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards joshtrichards merged commit 55efb80 into master May 24, 2024
11 checks passed
@joshtrichards joshtrichards deleted the docs-admin-remove-filelocking-toggle branch May 24, 2024 14:41
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants