Allow REDIS_CLUSTER environment variable to use Redis in cluster mode #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Martin <[email protected]> Signed-off-by: Nick Martin <[email protected]>
n1mmy
force-pushed
the
master
branch
3 times, most recently
from
06183c8 to
f756178
Compare
|
@J0WI I can give it shot when I have some free development time in the next week or two. I don't have a great testing environment at the moment, but I'll figure something out. Please don't wait for me though, if other things are ready to merge go ahead and merge them and I can update this PR for the new changes. |
|
After looking at the other PRs in more detail, I realize this PR needs to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Redis cluster instead of a single host allows for a more high-availability deployment.
This patch is only allows a single seed host. A more full implementation would have some way to support multiple seed hosts (eg a comma separated list, or multiple environment variables). However, this is enough to get started and works well in environments that have a single name/IP that will connect to a redis cluster (eg a load balancer or a kubernetes service).