Update redis.config.php | Set redis password from Docker secret (REDIS_HOST_PASSWORD_FILE) #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly set the redis password config from the REDIS_HOST_PASSWORD_FILE environment variable. Fix an issue similar to #1402 when using the REDIS_HOST_PASSWORD_FILE environment variable to provide the redis host secret. Signed-off-by: Vesperia Art <[email protected]>
VesperiaArt
changed the title
J0WI
reviewed
Jun 4, 2024
Not sure what to add, since the README already mention that REDIS_HOST_PASSWORD_FILE is supported for docker secrets. This PR fixes the nextcloud's redis config reading the password from this environment variable. Do you mean adding instruction for the user to apply the fix themselves ? |
tianon
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the redis password config from the REDIS_HOST_PASSWORD_FILE environment variable. Fix an issue similar to #1402 when using the REDIS_HOST_PASSWORD_FILE environment variable to provide the redis host secret.
I had the same problem as described in #1402 , except that I was using the REDIS_HOST_PASSWORD_FILE environment variable to provide the redis password value (like some other users in this aforementioned issue). The fix included in this PR has fixed the issue for me and finally freed my logs from getting filled with "NOAUTH Authentication required" . OCC commands also correctly work without printing "NOAUTH Authentication required".