Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tray icon not displaying "Open main dialog" #4484

Merged
merged 1 commit into from
May 16, 2022
Merged

Fix tray icon not displaying "Open main dialog" #4484

merged 1 commit into from
May 16, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented May 5, 2022 •
edited
Loading

This PR fixes a bug where the tray context menu never displays "Open main dialog", only "Add account", making the tray inoperable on GNOME.

Fixes #4476

@claucambra claucambra self-assigned this May 5, 2022
mgallien
mgallien reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, see my comments

src/gui/systray.h Outdated Show resolved Hide resolved
src/gui/systray.cpp Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/tray-context-menu branch 3 times, most recently from 241e964 to 566effc Compare May 5, 2022 20:51
@claucambra claucambra requested a review from mgallien May 5, 2022 21:56
@claucambra claucambra force-pushed the bugfix/tray-context-menu branch from 566effc to 5d0b9aa Compare May 6, 2022 08:06
@claucambra claucambra mentioned this pull request May 6, 2022
Closed
8 tasks
@claucambra claucambra force-pushed the bugfix/tray-context-menu branch 5 times, most recently from 9ba77c0 to 3a46cd0 Compare May 16, 2022 10:25
allexzander
allexzander reviewed May 16, 2022
View reviewed changes
src/gui/systray.cpp Outdated Show resolved Hide resolved
@allexzander allexzander self-requested a review May 16, 2022 11:52
allexzander
allexzander approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra Looks good. See my comment.

@claucambra claucambra force-pushed the bugfix/tray-context-menu branch 3 times, most recently from d93f88f to 5539119 Compare May 16, 2022 13:47
@claucambra claucambra force-pushed the bugfix/tray-context-menu branch from 5539119 to 364d02a Compare May 16, 2022 14:42
@claucambra claucambra merged commit 9d1c378 into master May 16, 2022
@claucambra claucambra deleted the bugfix/tray-context-menu branch May 16, 2022 14:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.6.0 milestone May 16, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 16, 2022
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4484-364d02a13f753f9e091f96305c55afddd8703cdd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@camilasan camilasan camilasan approved these changes

@mgallien mgallien Awaiting requested review from mgallien

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

[Bug]: main (blue background) UI gone in 3.5 under Gnome/Wayland/Ubuntu 22.04
5 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan @allexzander