Unbreak loading translations #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@antonio-rojas sorry for the delayed review due to the team being busy |
antonio-rojas
force-pushed
the
patch-1
branch
from
9f0ef69 to
7498f04
Compare
Done |
mgallien
approved these changes
Dec 10, 2021
claucambra
approved these changes
Dec 21, 2021
|
/rebase |
nextcloud-command
force-pushed
the
patch-1
branch
from
7498f04 to
4fd0f89
Compare
|
/rebase |
Commit 18ddb9d changed SHAREDIR to point to CMAKE_INSTALL_DATADIR, which is a relative path by default. This prevents the C++ code from finding the translations at runtime. Signed-off-by: Antonio Rojas <[email protected]>
nextcloud-command
force-pushed
the
patch-1
branch
from
4fd0f89 to
9d4d11d
Compare
|
AppImage file: Nextcloud-PR-4022-9d4d11df61275d578a5ebb1478e0afcd1df96273-x86_64.AppImage |
|
/backport to stable-3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 18ddb9d changed SHAREDIR to point to CMAKE_INSTALL_DATADIR, which is a relative path by default. This prevents the C++ code from finding the translations at runtime.