Rewrite of screen selection logic, plus synamic screen selection Wind…

…ow.qml Signed-off-by: Dominique Fuchs <[email protected]>
nextcloud · Jan 21, 2020 · 0697c81 · 0697c81
1 parent 77be672
commit 0697c81
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 45 deletions.
diff --git a/src/gui/systray.cpp b/src/gui/systray.cpp
@@ -95,6 +95,17 @@ bool Systray::isOpen()
     return _isOpen;
 }
 
+Q_INVOKABLE int Systray::screenIndex()
+{
+    auto qPos = QCursor::pos();
+    for (int i = 0; i < QGuiApplication::screens().count(); i++) {
+        if (QGuiApplication::screens().at(i)->geometry().contains(qPos)) {
+            return i;
+        }
+    }
+    return 0;
+}
+
 Q_INVOKABLE void Systray::setOpened()
 {
     _isOpen = true;
@@ -142,29 +153,13 @@ int Systray::calcTrayWindowX()
     int trayIconTopCenterX = (topRight - ((topRight - topLeft) * 0.5)).x();
     return trayIconTopCenterX - (400 * 0.5);
 #else
-QScreen* trayScreen = nullptr;
-#if (QT_VERSION >= QT_VERSION_CHECK(5,10,0))
-    if (this->geometry().left() == 0 || this->geometry().top() == 0) {
-        trayScreen = QGuiApplication::screenAt(QCursor::pos());
+    QScreen* trayScreen = nullptr;
+    if (QGuiApplication::screens().count() > 1) {
+        trayScreen = QGuiApplication::screens().at(screenIndex());
     } else {
-        trayScreen = QGuiApplication::screenAt(this->geometry().topLeft());
-    }
-#else
-    foreach (QScreen* screen, QGuiApplication::screens()) {
-        if (this->geometry().left() == 0 || this->geometry().top() == 0) {
-            if (screen->geometry().contains(QCursor::pos())) {
-                trayScreen = screen;
-            }
-        } else {
-            if (screen->geometry().contains(this->geometry().topLeft())) {
-                trayScreen = screen;
-            }
-        }
-    }
-    if (trayScreen == nullptr) {
         trayScreen = QGuiApplication::primaryScreen();
     }
-#endif
+
     int screenWidth = trayScreen->geometry().width();
     int screenHeight = trayScreen->geometry().height();
     int availableWidth = trayScreen->availableGeometry().width();
@@ -210,30 +205,13 @@ int Systray::calcTrayWindowY()
     // don't use availableGeometry() here, because this also excludes the dock
     return 22+6;
 #else
-QScreen* trayScreen = nullptr;
-#if (QT_VERSION >= QT_VERSION_CHECK(5,10,0))
-    if (this->geometry().left() == 0 || this->geometry().top() == 0) {
-    trayScreen = QGuiApplication::screenAt(QCursor::pos());
+    QScreen* trayScreen = nullptr;
+    if (QGuiApplication::screens().count() > 1) {
+        trayScreen = QGuiApplication::screens().at(screenIndex());
     } else {
-        trayScreen = QGuiApplication::screenAt(this->geometry().topLeft());
-    }
-#else
-    foreach (QScreen* screen, QGuiApplication::screens()) {
-        if (this->geometry().left() == 0 || this->geometry().top() == 0) {
-            if (screen->geometry().contains(QCursor::pos())) {
-                trayScreen = screen;
-            }
-        } else {
-            if (screen->geometry().contains(this->geometry().topLeft())) {
-                trayScreen = screen;
-            }
-        }
-    }
-    if (trayScreen == nullptr) {
         trayScreen = QGuiApplication::primaryScreen();
     }
-#endif
-    int screenWidth = trayScreen->geometry().width();
+
     int screenHeight = trayScreen->geometry().height();
     int availableHeight = trayScreen->availableGeometry().height();
 

diff --git a/src/gui/systray.h b/src/gui/systray.h
@@ -57,6 +57,7 @@ class Systray
     Q_INVOKABLE bool syncIsPaused();
     Q_INVOKABLE void setOpened();
     Q_INVOKABLE void setClosed();
+    Q_INVOKABLE int screenIndex();
 
 signals:
     void currentUserChanged();

diff --git a/src/gui/tray/UserLine.qml b/src/gui/tray/UserLine.qml
@@ -1,5 +1,5 @@
 import QtQuick 2.9
-import QtQuick.Window 2.2
+import QtQuick.Window 2.3
 import QtQuick.Controls 2.2
 import QtQuick.Layouts 1.2
 

diff --git a/src/gui/tray/Window.qml b/src/gui/tray/Window.qml
@@ -1,7 +1,7 @@
 import QtQml 2.1
 import QtQml.Models 2.1
 import QtQuick 2.9
-import QtQuick.Window 2.2
+import QtQuick.Window 2.3
 import QtQuick.Controls 2.2
 import QtQuick.Layouts 1.2
 import QtGraphicalEffects 1.0
@@ -58,8 +58,8 @@ Window {
             trayWindow.show();
             trayWindow.raise();
             trayWindow.requestActivate();
-            trayWindow.setX( systrayBackend.calcTrayWindowX());
-            trayWindow.setY( systrayBackend.calcTrayWindowY());
+            trayWindow.setX( Qt.application.screens[systrayBackend.screenIndex()].virtualX + systrayBackend.calcTrayWindowX());
+            trayWindow.setY( Qt.application.screens[systrayBackend.screenIndex()].virtualY + systrayBackend.calcTrayWindowY());
             systrayBackend.setOpened();
             userModelBackend.fetchCurrentActivityModel();
         }