Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainer(image): Fix package path #6653

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

niclasheinz
Copy link
Contributor

  • Resolves: is not related to an issue
  • Target version: main

Summary

I wanted to work on an issue and started the workspace. Then I got an error message saying that the dockerimge could not be downloaded. After a bit of research, I saw that the path is outdated. That's why I did the PR

  • .devcontainer/devcontainer.json: Changed the image from ghcr.io/juliushaertl/nextcloud-dev-php81:latest to ghcr.io/juliusknorr/nextcloud-dev-php81:latest.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@niclasheinz
Copy link
Contributor Author

Good morning @luka-nextcloud

Do you know why the Job Matrix is throwing an error on this change? I looked at the workflow file and saw that it only has a defined timeout:
https://github.com/nextcloud/deck/actions/runs/12714799306/workflow#L83

But maybe you know more?

Greetings, Niclas

@juliusknorr
Copy link
Member

Looks like a temporary network problem, restated the check

@juliusknorr juliusknorr merged commit 351af0b into nextcloud:main Jan 13, 2025
30 checks passed
@juliusknorr
Copy link
Member

Thanks a lot for your contribution 🎉

@niclasheinz niclasheinz deleted the fix-devcontainer branch January 13, 2025 11:27
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants