fix(controls): use primary when filter is active #5299
Conversation
fitrahmunir
force-pushed
the
fix/use-primary-when-filter-is-active
branch
from
c644550
to
904ef02
Compare
| background-color: #212121; | ||
| } | ||
| &.button-vue--vue-primary { | ||
| background-color: var(--color-primary-element); |
There was a problem hiding this comment.
This should already be set through the type itself
There was a problem hiding this comment.
I also need this style to override the background color of the filter button when the filter is checked
src/components/Controls.vue
Outdated
| background-color: rgb(245, 245, 245); | ||
| [data-themes=dark] & { | ||
| background-color: #212121; | ||
| } |
There was a problem hiding this comment.
Can you elaborate what that special styling would be needed for? I couldn't notice it would have any effect when testing out the PR. In general we should avoid any hard coded color values and use available css vars wherever appropriate these days.
There was a problem hiding this comment.
The difference is that when the popover opens, the filter button doesn't look like it's been pressed.
With styles:
Without styles:
There was a problem hiding this comment.
I refer to Talk when the popover opens, the filter button will be like this
There was a problem hiding this comment.
After checking the existing color vars, the required style is just like this
There was a problem hiding this comment.
Ah good point then, especially with those variables that seems good
There was a problem hiding this comment.
Thanks, I will update the code
|
Thanks a lot for your pull request. I left some comments inline to clarify. |
fitrahmunir
force-pushed
the
fix/use-primary-when-filter-is-active
branch
2 times, most recently
from
ac2fabd
to
9513c39
Compare
Signed-off-by: Fitrah Munir <[email protected]>
fitrahmunir
force-pushed
the
fix/use-primary-when-filter-is-active
branch
from
9513c39
to
80e0935
Compare
|
Thanks a lot for your contribution @fitrahfm |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
Added a conditional button type and fixed filter button styles when the popover is open
TODO
Checklist