Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card layout polishing #5264

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Card layout polishing #5264

merged 4 commits into from
Nov 13, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 10, 2023

  • fix: Fix spacing and reserved scrollbar space
  • fix: Align card details better to take less space and align all possible badges more equally
    • Do not take extra space for the menu button
    • Give the title as much available space in width as possible

@nextcloud/designers Would appreciate some feedback. One thing I'm unsure is that the labels and the due date badge have a similar design, but the rounded corners seem for fitting than the previous style.

Fixes #1672
Fixes #4299

Before After
Screenshot 2023-11-10 at 11 51 22 Screenshot 2023-11-10 at 15 59 12

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! Looks so much better :)
Only 3 small details:

  • increase the horizontal padding of the labels by a couple of pixels, similar to the due date indicator
  • the number of sub tasks indicator (☑️ 1/3) seems to be slightly lower than it should be, it should be center aligned with the avatars
  • we could also think about reducing the bottom padding of the card itself by a couple of pixels. The new screenshots definitely look better than the old one, but it could be reduced by 2-3 pixels. For example, the card with only badges seems to have some extra space at the bottom.

Screenshot_20231110_131808_Firefox.jpg

But those are small comments, overall it looks great! :)

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 10, 2023

Thanks for the feedback. All addressed and also slightly updated the due date indicator to be a bit more different from the labels. Screenshot is updated.

@juliusknorr juliusknorr merged commit 05020b0 into main Nov 13, 2023
14 checks passed
@juliusknorr juliusknorr deleted the fix/design branch November 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants