-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card layout polishing #5264
Merged
Merged
Card layout polishing #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/design
branch
from
November 10, 2023 09:26
ebef50a
to
4dfbd19
Compare
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/design
branch
from
November 10, 2023 11:04
4dfbd19
to
af9611b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice! Looks so much better :)
Only 3 small details:
- increase the horizontal padding of the labels by a couple of pixels, similar to the due date indicator
- the number of sub tasks indicator (☑️ 1/3) seems to be slightly lower than it should be, it should be center aligned with the avatars
- we could also think about reducing the bottom padding of the card itself by a couple of pixels. The new screenshots definitely look better than the old one, but it could be reduced by 2-3 pixels. For example, the card with only badges seems to have some extra space at the bottom.
But those are small comments, overall it looks great! :)
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
fix/design
branch
from
November 10, 2023 14:59
af9611b
to
a52de61
Compare
Thanks for the feedback. All addressed and also slightly updated the due date indicator to be a bit more different from the labels. Screenshot is updated. |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
luka-nextcloud
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nextcloud/designers Would appreciate some feedback. One thing I'm unsure is that the labels and the due date badge have a similar design, but the rounded corners seem for fitting than the previous style.
Fixes #1672
Fixes #4299