fix: Avoid too large index on postgres as indexing just the last_editor column is enough #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
|
/backport to stable27 |
…or column is enough Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/postgres-index
branch
from
f8b07f6
to
029082b
Compare
mejo-
approved these changes
Nov 6, 2023
|
/backport to stable27 |
|
/backport 029082b to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres as limitations on the index size and the length is actually not applied there. This drops the index and recreates one just with the first column. As we always set or reset the last_editor together with the description_prev column having the index only for the small column is enough to query the relevant entries in the mapper.
Otherwise updating might fail with the following error: