-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add attributes aria-label= and title= to Filters & View Modes buttons #5133
add attributes aria-label= and title= to Filters & View Modes buttons #5133
Conversation
I do not know why the
The front-end test fails with:
However, that test fails on a fresh clone from |
Signed-off-by: Private Maker <[email protected]>
f1725de
to
2ab186a
Compare
Signed-off-by: Julius Härtl <[email protected]>
@juliushaertl sorry I was away to fix the eslint thing. Thanks for merging 😄 |
No worries, thanks for the contribution :) |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
The two middle buttons used to toggle filter and show/hide cards
I added a couple
aria-label="..."
andtitle="..."
attributes to the components and it resolved the issue.Checklist