Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 24, 2020

Bumps moment from 2.25.3 to 2.26.0.

Changelog

Sourced from moment's changelog.

2.26.0 See full changelog

  • Release May 19, 2020

TypeScript fixes and many locale improvements

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies javascript Pull requests that update Javascript code labels May 24, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2020

Codecov Report

Merging #1952 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1952   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files          77       77           
  Lines        3842     3842           
=======================================
  Hits         2187     2187           
  Misses       1655     1655           

@stefan-niedermann
Copy link
Member

Just an idea, have you considered to use date-fns instead of momentjs for better treeshaking?

@juliusknorr
Copy link
Member

Ah very good point, actually date-fns is already pulled in by vue2-datepicker from https://github.com/nextcloud/nextcloud-vue. As far as I see it now we are only using moment to format and calculate dates switching should be quite easy.

@juliusknorr juliusknorr self-assigned this May 25, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/moment-2.26.0 branch 3 times, most recently from 081377d to 242a344 Compare May 25, 2020 08:11
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/moment-2.26.0 branch from 242a344 to ac81089 Compare May 25, 2020 08:18
@juliusknorr juliusknorr merged commit b20c5a5 into master May 27, 2020
@juliusknorr juliusknorr deleted the dependabot/npm_and_yarn/moment-2.26.0 branch May 27, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants