Refactor image generation #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianlupus
force-pushed
the
dev/image-generation
branch
from
1175848 to
78e31c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 22.42% 28.50% +6.08%
==========================================
Files 21 29 +8
Lines 1476 1540 +64
==========================================
+ Hits 331 439 +108
+ Misses 1145 1101 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seyfeb
approved these changes
Mar 27, 2022
Collaborator
seyfeb
left a comment
seyfeb
left a comment
There was a problem hiding this comment.
Should be fine. There are just some small comments from my side
Signed-off-by: Christian Wolf <[email protected]>
Added test for complete coverage Added dropping of thumbnails Prevent accidential removal of primary image Signed-off-by: Christian Wolf <[email protected]>
Added tests for helper classes Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
force-pushed
the
dev/image-generation
branch
from
ee747a4 to
7a7d471
Compare
Adding the spelling issues from the code review process Signed-Off-By: Christian Wolf <[email protected]> Co-authored-by: Sebastian Fey <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
I have to make sure I got all, thus a first commit. Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
force-pushed
the
dev/image-generation
branch
from
1734577 to
e8ea33a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make the image management cleaner and better handlable. The main intent was to migrate the code into an (automatically) testable state.