Skip to content

Make AppControls breadcrums sticky (#834) #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 3 commits into from
Feb 20, 2022
Merged

Make AppControls breadcrums sticky (#834) #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fe1ad4
Make AppControls breadcrums sticky (#834)
MarcelRobitaille Feb 9, 2022
66db68c
Make the code styler happy
christianlupus Feb 20, 2022
2ac07d5
Update changelog
christianlupus Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
[#880](https://github.com/nextcloud/cookbook/pull/880) @christianlupus
- Usage of caches for NPM speedup
[#883](https://github.com/nextcloud/cookbook/pull/883) @christianlupus
- Make the controls sticky on top
[#888](https://github.com/nextcloud/cookbook/pull/888) @MarcelRobitaille

### Documentation
- Added clarification between categories and keywords for users
[#889](https://github.com/nextcloud/cookbook/pull/889) @MarcelRobitaille


## 0.9.9 - 2022-01-13

### Fixed
Expand Down
11 changes: 11 additions & 0 deletions src/components/AppControls.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,19 @@ export default {

<style scoped>
.wrapper {
/* Sticky is better than fixed because fixed takes the element out of flow,
which breaks the height, putting elements underneath */
position: sticky;

/* This is competing with the recipe instructions which have z-index: 1 */
z-index: 2;

/* The height of the nextcloud header */
top: 50px;
width: 100%;
padding-left: 4px;
border-bottom: 1px solid var(--color-border);
background-color: var(--color-main-background);
}

.active {
Expand Down