Filter empty pasted lines before single line check #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRobitaille
force-pushed
the
filter-paste
branch
from
6477f3e to
7ed21c4
Compare
seyfeb
approved these changes
Feb 19, 2022
Collaborator
seyfeb
left a comment
seyfeb
left a comment
There was a problem hiding this comment.
I didn’t check and run this, but it look good to me. I also prefer your solution of using a filter method - makes sense!
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 21.22% 21.22%
=======================================
Files 20 20
Lines 1555 1555
=======================================
Hits 330 330
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Marcel Robitaille <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
force-pushed
the
filter-paste
branch
from
7ed21c4 to
09bebad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while trying to implement something else.
When pasting multiple lines, the empty lines should be filtered out before checking if only one line was pasted, shouldn't they?
For example, if the following is pasted:
"this is a test\n", this will be split into["this is a test", ""]andthis.singleLinePastedwill be false even though later the empty item will be filtered out and the array will contain a single element.I also replaced the for loop with the filter method, I hope that's ok. I think it's more clear what is going on.