Reactivate translation integration #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Wolf <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
=======================================
Coverage 21.22% 21.22%
=======================================
Files 20 20
Lines 1555 1555
=======================================
Hits 330 330
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
force-pushed
the
fix/875-missing-appinfo
branch
from
d600399 to
3451945
Compare
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #875
The main app's info XML file was removed to avoid conflicts when new releases are generated. Then, a new info file needs to be rewritten. This is handled by another workflow. When the main XML file gets modified, this might get overwritten in an not directly predictable way. Therefore the dist file was considered the single source of truth.
This PR should cover the problem by adding another test to all PRs and warn about altered/diverged XML files.