Fix/763: Tidy up database on migration #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with PHPUnit Signed-off-by: Christian Wolf <[email protected]> Make running test case valid Signed-off-by: Christian Wolf <[email protected]> Tidy up test case Signed-off-by: Christian Wolf <[email protected]> Update phpunit configuration file Signed-off-by: Christian Wolf <[email protected]> Rename cases to avoid spaces in names Signed-off-by: Christian Wolf <[email protected]> Corrected assertions and sorting Signed-off-by: Christian Wolf <[email protected]> Updated test code to have corrct array keys involved. Signed-off-by: Christian Wolf <[email protected]> Added some comments Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]> Corrected typo on migration step Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]> Final fix related to having clause Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]> Remove instanciated object on tear down Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
===========================================
+ Coverage 0.98% 3.89% +2.91%
- Complexity 454 459 +5
===========================================
Files 20 20
Lines 1428 1465 +37
===========================================
+ Hits 14 57 +43
+ Misses 1414 1408 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the problems in the recent migrations regarding old data in the tables that cause trouble with the indices.
Closes #763
Closes #762