Skip to content

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Apr 6, 2021

@seyfeb seyfeb added javascript Pull requests that update Javascript code Frontend Issue or PR related to the frontend code labels Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #678 (37db96c) into master (a732dfc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 37db96c differs from pull request most recent head 5c3a3c2. Consider uploading reports for the commit 5c3a3c2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             master    #678      +/-   ##
===========================================
- Coverage      0.96%   0.95%   -0.02%     
- Complexity      453     458       +5     
===========================================
  Files            17      18       +1     
  Lines          1444    1460      +16     
===========================================
  Hits             14      14              
- Misses         1430    1446      +16     
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 458.00 <5.00> (+5.00)
unittests 0.95% <0.00%> (-0.02%) 458.00 <5.00> (+5.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Migration/Version000000Date20210427082010.php 0.00% <0.00%> (ø) 5.00 <5.00> (?)

@seyfeb seyfeb force-pushed the feature/enhancedTagCloud branch from 694835c to 97fb3b0 Compare April 6, 2021 22:42
@seyfeb seyfeb marked this pull request as ready for review April 6, 2021 22:57
@seyfeb seyfeb requested a review from christianlupus April 7, 2021 06:45
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me and function is given in a quick test.

@christianlupus christianlupus force-pushed the feature/enhancedTagCloud branch from bbe5512 to 7cc29ed Compare April 27, 2021 08:11
@seyfeb seyfeb force-pushed the feature/enhancedTagCloud branch from 7cc29ed to 5c3a3c2 Compare April 28, 2021 10:17
@seyfeb seyfeb merged commit 5c0b926 into master Apr 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/enhancedTagCloud branch April 28, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Issue or PR related to the frontend code javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort keywords alphabetic Ability to hide tag cloud

3 participants