Skip to content

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Feb 25, 2021

This PR has quite a lot of changes but mostly changes for a consistent code base. There are also some minor bugfixes.

  • updates eslint settings
  • makes js code eslint compatible
  • minor bugfixes

Some minor bugfixes

Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #615 (f04c07f) into master (d8fd6ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #615   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      444     444           
========================================
  Files            14      14           
  Lines          1385    1385           
========================================
  Hits             14      14           
  Misses         1371    1371           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@seyfeb seyfeb marked this pull request as draft February 25, 2021 15:32
@seyfeb seyfeb changed the title Code cleanup & some bugfixes Eslint, Code cleanup, some bugfixes Feb 25, 2021
@seyfeb seyfeb marked this pull request as ready for review February 25, 2021 21:12
@seyfeb seyfeb marked this pull request as draft February 26, 2021 14:48
@seyfeb seyfeb force-pushed the maintenance/js branch 2 times, most recently from 0d3a32e to bb49a45 Compare February 26, 2021 15:53
@seyfeb seyfeb marked this pull request as ready for review February 26, 2021 15:58
@christianlupus christianlupus merged commit cc3082f into master Feb 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the maintenance/js branch February 27, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants