Skip to content

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Jan 31, 2021

Closes #537

The test environment is updated and enhanced to allow better integration testing

  • Make the run-local.sh script command line parameter aware
  • Trigger pulls/builds from docker explicitly
  • Build a docker image to use as a basis for integration tests
  • Better structure the file for better understandability, define useful chunks of functionality
  • Prepare integration testing using docker + phpunit + setup (bash) script
  • [optional] Build a daily/weekly set of prebuilt docker images on the docker hub for faster test setup (only the dependencies)
  • [optional] run the test routines in a docker container in order to have the same commands on GH actions and locally (?)
  • Allow tests also for unsupported NC versions
  • Update documentation for testing

@christianlupus christianlupus self-assigned this Jan 31, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #564 (217ff45) into master (10178b2) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #564   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      440     440           
========================================
  Files            13      13           
  Lines          1381    1379    -2     
========================================
  Hits             14      14           
+ Misses         1367    1365    -2     
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <0.00%> (ø) 7.00% <0.00%> (ø%)

@christianlupus christianlupus force-pushed the dev/537-overhaul-tests branch 6 times, most recently from e90bccc to ef93793 Compare February 5, 2021 17:03
Signed-off-by: Christian Wolf <[email protected]>
Create apache container with php-fpm for integration testing

Signed-off-by: Christian Wolf <[email protected]>

Added NGINX as http server alternative

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>

Removed apt-get verbosity

Signed-off-by: Christian Wolf <[email protected]>
Switch to overlay based file structure
Usage of volume and rsync instead of overlay file system.

Signed-off-by: Christian Wolf <[email protected]>
Added script to build nightly a CI image
By default fetch the latest prebuilt image from docker hub if starting from scratch

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review February 7, 2021 14:28
@christianlupus
Copy link
Collaborator Author

I will merge this now. I hope it is working as assumed but if errors arise, we will have to tackle them in time.

@christianlupus christianlupus merged commit bc7b808 into master Feb 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/537-overhaul-tests branch February 7, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overhaul of the test environment

2 participants