Skip to content

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Jan 19, 2021

  • Removed navigation toggle next to breadcrumbs
  • Introduced left-navigation-pane visibility state to Vuex store
  • toggling navigation state via Vuex instead of querying for element ids

Closes 514, closes 534

…rom the breadcrumbs bar.

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb added the Frontend Issue or PR related to the frontend code label Jan 19, 2021
@seyfeb seyfeb requested a review from christianlupus January 19, 2021 21:04
@seyfeb seyfeb changed the title Maintenance/issue514 Fix some navigation pane issues Jan 19, 2021
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb seyfeb force-pushed the maintenance/issue514 branch from 894cd61 to 69d4508 Compare January 19, 2021 21:07
@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #544 (b4c0535) into master (836be88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #544   +/-   ##
========================================
  Coverage      0.87%   0.87%           
  Complexity      432     432           
========================================
  Files            13      13           
  Lines          1364    1364           
========================================
  Hits             12      12           
  Misses         1352    1352           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 0.87% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@seyfeb seyfeb merged commit 1855ce9 into master Jan 19, 2021
@seyfeb seyfeb deleted the maintenance/issue514 branch January 19, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Issue or PR related to the frontend code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad alignment of images in mobile (narrow) version Use events in Vue to change states

2 participants