Update ingredient list visuals #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #512 +/- ##
========================================
Coverage 0.90% 0.90%
Complexity 416 416
========================================
Files 13 13
Lines 1319 1319
========================================
Hits 12 12
Misses 1307 1307
Flags with carried forward coverage won't be shown. Click here to find out more. |
seyfeb
force-pushed
the
feature/updateIngredientListVisuals
branch
from
80601ea to
5070dd2
Compare
christianlupus
approved these changes
Jan 15, 2021
| li.unindented { | ||
| position: relative; | ||
| left: -1.25em; |
Collaborator
There was a problem hiding this comment.
This can cause trouble. After #515 it might be better to do margin-left: 0px; instead.
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
christianlupus
force-pushed
the
feature/updateIngredientListVisuals
branch
from
40f9cce to
70aa12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the existence of subgroups in the ingredient list (starting with ##) the ingredients are more or less indented.
The vertical overlap of checkmark and ingredient text, that appeared when there was a line break in the text, is removed.
Also a hanging indent is introduced to make it visually clear when there is a line break within a single ingredient.
Previously:
With subgroup:
Without subgroup:
