Skip to content

Prevent img loaded event being handled twice #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 2 commits into from
Dec 30, 2020
Merged

Prevent img loaded event being handled twice #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baca7ca
Removed image-loaded events after they are handled in lazyloading images
seyfeb Dec 30, 2020
61e556d
Updated CHANGELOG
seyfeb Dec 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@
[#447](https://github.com/nextcloud/cookbook/pull/447) @christianlupus
- Recipe-editing Vue components are not tightly coupled anymore
[#386](https://github.com/nextcloud/cookbook/pull/386/) @seyfeb
- Fixed trying to remove already removed img DOM nodes in image lazyloading, fixes #462
[#463](https://github.com/nextcloud/cookbook/pull/463/) @seyfeb

### Removed
- Travis build system
Expand Down
3 changes: 3 additions & 0 deletions src/components/LazyPicture.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,14 @@ export default {

// callback for fully-loaded image event
const onThumbnailFullyLoaded = () => {
img.removeEventListener('load', onThumbnailFullyLoaded)
el.removeChild(imgPlaceholder)
$this.isLoading = false
}

// callback for preview-image-loaded event
const onThumbnailPreviewLoaded = () => {
imgPlaceholder.removeEventListener('load', onThumbnailPreviewLoaded)
img.addEventListener('load', onThumbnailFullyLoaded)
$this.$once('hook:destroyed', () => {
img.removeEventListener('load', onThumbnailFullyLoaded)
Expand Down