Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/run-tests/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ The following options are available to manage the docker images:

Typically, one will use the `--create-images` flag which will pull any images and rebuild the existing images if anything has changed.

It is hightly suggested to set the environment variable `COMPOSE_DOCKER_CLI_BUILD` to `1`. This will avoid building the images from scratch as a online cached version (nightly build) can be used instead. If your setup does not break, you can simply call `export COMPOSE_DOCKER_CLI_BUILD=1` before the first invocation of `run-locally.sh` once in each terminal you open.

To push images credentials are needed. This is only required to speed up the the build prucess for other users. You will not have to do this unless you know exacly what it does.

### Handling the helper containers
Expand Down
1 change: 1 addition & 0 deletions .github/actions/run-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ runs:
export INPUT_DB=${{ inputs.db }} &&
export PHP_VERSION=${{ inputs.phpVersion }} &&
export HTTP_SERVER=${{ inputs.server }} &&
export COMPOSE_DOCKER_CLI_BUILD=1 &&
./run-locally.sh
--pull
--create-images
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-test-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ jobs:
| docker login
--username ${{ secrets.DOCKER_HUB_USERNAME }}
--password-stdin &&
export COMPOSE_DOCKER_CLI_BUILD=1 &&
PHP_VERSION=${{ matrix.phpVersion }}
./run-locally.sh --pull --create-images --push-images
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,16 @@ jobs:
run: >-
CONTENT="{\"download\": \"${{ steps.upload_asset.outputs.browser_download_url }}\", \"signature\": \"$(cat /tmp/signature | tr -d '\n')\"}" &&
echo "$CONTENT" &&
curl -X POST
curl_out=$(curl -X POST
https://apps.nextcloud.com/api/v1/apps/releases
-H "Authorization: Token $TOKEN"
-H "Content-Type: application/json"
-d "$CONTENT"
-w '\n%{http_code}\n');
ret=$? &&
code=$(echo "$curl_out" | tail -n 1) &&
msg=$(echo "$curl_out" | head -n -1) &&
echo "::set-output name=code::$code" &&
echo "::set-output name=msg::$msg" &&
echo "Result ($code): $msg" &&
echo "$code" | grep '^\([^45][0-9][0-9]\)$'
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
[#546](https://github.com/nextcloud/cookbook/pull/546/) @seyfeb
- Push docker images for different PHP versions
[#574](https://github.com/nextcloud/cookbook/pull/574) @christianlupus
- Enhanced the CI scripts to be more verbose regarding issues
[#452](https://github.com/nextcloud/cookbook/pull/452) @christianlupus

### Removed
- Removal of old contoller no longer in use
Expand Down