Skip to content

Improved Keyword filtering #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christianlupus merged 9 commits into from
Dec 28, 2020
Merged

Improved Keyword filtering #408

christianlupus merged 9 commits into from
Dec 28, 2020

Conversation

@seyfeb
Copy link
Collaborator

@seyfeb seyfeb commented Nov 22, 2020 •
edited
Loading

I made some changes to improve the keyword filtering in the recipe-list view. With this PR

  • keywords show number of recipes that have the keyword assigned
  • keywords are ordered by the number
  • when keywords are selected, non-selectable keywords are moved to the end of the list
  • selected keyword are moved to the beginning of the list for easy discovery
  • a maximum size for the keyword-selection area is defined to prevent the page getting cluttered with many keywords. The area can be scrolled vertically to allow access to all keywords.

@sam-19 maybe you can review this PR?

@seyfeb seyfeb force-pushed the feature/improvedTagSelection branch from 485d5ce to f79e870 Compare November 22, 2020 23:16
@codecov
Copy link

codecov bot commented Nov 22, 2020 •
edited
Loading

Codecov Report

Merging #408 (bee71fa) into master (d8f0f80) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #408   +/-   ##
========================================
  Coverage      0.91%   0.91%           
  Complexity      414     414           
========================================
  Files            13      13           
  Lines          1307    1307           
========================================
  Hits             12      12           
  Misses         1295    1295
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
unittests 0.91% <0.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Db/RecipeDb.php 0.00% <0.00%> (ø) 56.00 <0.00> (ø)

@christianlupus
Copy link
Collaborator

christianlupus commented Nov 23, 2020

As this is mainly Vue-related stuff, I added sam as a reviewer. I will have a look once I find a few spare minutes.

@seyfeb seyfeb force-pushed the feature/improvedTagSelection branch from ba11f2c to 000506d Compare November 23, 2020 11:05
@seyfeb seyfeb marked this pull request as draft November 23, 2020 11:06
@seyfeb
Copy link
Collaborator Author

seyfeb commented Nov 23, 2020

I just converted this PR to a draft as I found, that the recipe search is not showing the correct keywords. I guess this is related to the php part, I’ll have a look at this later.

@seyfeb seyfeb force-pushed the feature/improvedTagSelection branch from 000506d to 2085a38 Compare November 23, 2020 17:09
@seyfeb seyfeb marked this pull request as ready for review November 23, 2020 17:10
christianlupus
christianlupus approved these changes Dec 6, 2020
View reviewed changes
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I checked the visual representation and it seems to work well.

@christianlupus
Copy link
Collaborator

christianlupus commented Dec 6, 2020

@sam-19 please give your statement. If you do not find the time, we can merge and fix bugs later if they happened...

@christianlupus christianlupus force-pushed the feature/improvedTagSelection branch from 2085a38 to dd7891c Compare December 6, 2020 17:52
@christianlupus
Copy link
Collaborator

christianlupus commented Dec 21, 2020

This PR has conflicts with the lazy-loader feature recently added. @seyfeb sorry, you might need to update this as well.

@seyfeb seyfeb force-pushed the feature/improvedTagSelection branch from dd7891c to 6852396 Compare December 22, 2020 15:03
@seyfeb @christianlupus
Added optional count to keyword component
1ffc5ec 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Adjusted recipe view for updated kyword component
d59659b 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Limit keyword space in app index, showing number of available recipes…
b7d6eb6 
… in keyword

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Move unselectable keywords to the end of the list
c2c17f4 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Applying updated tag visualization to search component
4071b80 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Updated CHANGELOG
0338eb8 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Added tooltips for description and reordering animation
b43e0d8 
Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Selected keywords are moved to the front
928d2dd 
Added tooltip for clicking on keyword in recipe view
Some code cleanup

Signed-off-by: Sebastian Fey <[email protected]>
@seyfeb @christianlupus
Fixed only partly returned keywords from recipe search
1285536 
Signed-off-by: Sebastian Fey <[email protected]>
@christianlupus christianlupus force-pushed the feature/improvedTagSelection branch from 6852396 to 1285536 Compare December 28, 2020 16:36
@christianlupus christianlupus merged commit f99845e into nextcloud:master Dec 28, 2020
@seyfeb seyfeb deleted the feature/improvedTagSelection branch December 30, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianlupus christianlupus christianlupus approved these changes

@sam-19 sam-19 Awaiting requested review from sam-19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seyfeb @christianlupus