Support dateCreated and dateModified fields #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seyfeb
force-pushed
the
feature/addDateCreated
branch
from
2458c5f to
bafbf87
Compare
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
The static code analysis looks good. I would like to try it in a test instance then I will approve it.
christianlupus
force-pushed
the
feature/addDateCreated
branch
from
bafbf87 to
d071358
Compare
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
===========================================
- Coverage 0.92% 0.92% -0.01%
- Complexity 410 412 +2
===========================================
Files 13 13
Lines 1300 1304 +4
===========================================
Hits 12 12
- Misses 1288 1292 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Sebastian Fey <[email protected]> Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
Signed-off-by: Sebastian Fey <[email protected]>
christianlupus
force-pushed
the
feature/addDateCreated
branch
from
d071358 to
6392218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #131, I added schema.org Recipe’s
dateCreatedanddateModifiedfields to the recipe view.These also set/updated when creating or updating a recipe.
The recipe view
Date & time are localized.