Skip to content

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Mar 4, 2025

Topic and Scope

This is just a quick fix for #2667.

Concerns/issues

Not thoroughly tested but seems to work on NC32 (aka master).

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Test Results

   12 files    584 suites   1m 38s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit 1e3f3e8.

@christianlupus christianlupus force-pushed the maintenance/nc-compatibility-flag branch from 1e3f3e8 to 3502d13 Compare March 5, 2025 11:17
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus linked an issue Mar 5, 2025 that may be closed by this pull request
@christianlupus christianlupus enabled auto-merge March 5, 2025 11:19
@christianlupus christianlupus merged commit 5e72ae6 into master Mar 5, 2025
21 checks passed
@christianlupus christianlupus deleted the maintenance/nc-compatibility-flag branch March 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nextcloud 31 support

3 participants