Fix a lot of psalm issues #2628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
fix/psalm
branch
from
067f974 to
fd0d659
Compare
Test Results 12 files 584 suites 1m 37s ⏱️ Results for commit b544cf5. ♻️ This comment has been updated with latest results. |
provokateurin
force-pushed
the
fix/psalm
branch
from
fd0d659 to
f2fb03b
Compare
provokateurin
force-pushed
the
fix/psalm
branch
from
f2fb03b to
4b71690
Compare
Member
Author
|
Fixes from nextcloud/server#50035 are now included, only stubs are missing to have an completely empty baseline. |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…orphic calls Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
…) with named arguments Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
christianlupus
force-pushed
the
fix/psalm
branch
from
4b71690 to
b3af7b1
Compare
Signed-off-by: Christian Wolf <[email protected]>
christianlupus
approved these changes
Mar 5, 2025
Collaborator
christianlupus
left a comment
christianlupus
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing these
Member
Author
|
I wasn't sure if I was supposed to update the changelog, since these changes are nothing that will impact any user. |
Collaborator
|
That is true, but otherwise, the changelog guard will bite you 😛. And I put it in the Maintenance category, that is okay, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
#1706
All the issues with JSONResponse will go away when nextcloud/server#50035 is merged and OCP is updated here.
I think after that all remaining issues are related to missing stubs, which I can also make a PR for after this one is merged.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.