Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changelog/current/2464-fix-changelog-checker.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Fixed
- Prevent failure of changlog builder when parsing dependabot PRs without explicit changelog stub
[backported #2461](https://github.com/nextcloud/cookbook/pull/2461)

7 changes: 5 additions & 2 deletions .github/workflows/pull-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,15 @@ jobs:
echo "### No changelog was needed"
echo ""
echo "No changelog entry was found so far."
echo "This is okay, as no files have been modified that would require a changelog entry."
echo "You might consider if adding a changelog entry would be benefical as significant changes have been made."
echo -n "This is okay, as no files have been modified that would require a changelog entry. "
echo -n "You might consider if adding a changelog entry would be benefical as significant changes have been made. "
echo 'The changelog should be in a file starting with `.changelog/current/${{ github.event.number }}-`.'
} > $GITHUB_STEP_SUMMARY
fi
if: ${{ steps.diff.outputs.num_lines == 0 }}
- name: Install Python package
run: pip install --user virtualenv pipenv
if: ${{ steps.diff.outputs.num_lines != 0 }}
- name: Test creation of changelog
run: |
cd .helpers/changelog
Expand All @@ -108,6 +110,7 @@ jobs:
python -m changelog_builder --token token --ci --pr ${{ github.event.number }} ../../.changelog/current/* 2>&1
echo '```'
} >> $GITHUB_STEP_SUMMARY
if: ${{ steps.diff.outputs.num_lines != 0 }}

todo-checker:
name: Check for added todo messages
Expand Down