Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Topic and Scope

Currently, the automerge of the dependabot fails. Dependabot does not create changelog stubs. Although this is generally okay for some files to change without explicit changelog, the generation of the GitHub step summary in the actions tab involves so far a generation of the total Changelog. This fails if there is no matching changelog present.

Concerns/issues

Should be save to merge, as in the workflow, either the error no changelog found is triggered of the python script is run.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@codecov
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (017f9a1) to head (ec3f508).
Report is 76 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2461      +/-   ##
==========================================
+ Coverage   78.51%   78.55%   +0.04%     
==========================================
  Files          95       95              
  Lines        2755     2761       +6     
==========================================
+ Hits         2163     2169       +6     
  Misses        592      592              
Flag Coverage Δ
integration 21.11% <ø> (-0.05%) ⬇️
migration 5.46% <ø> (-0.02%) ⬇️
unittests 56.42% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Aug 25, 2024

Test Results

   12 files    584 suites   1m 32s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit abe56b3.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus force-pushed the fix/allow-automerge-dependabot-prs branch from abe56b3 to d8e1945 Compare August 25, 2024 09:31
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus marked this pull request as ready for review August 25, 2024 09:36
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 86c0933 into master Aug 25, 2024
@christianlupus christianlupus deleted the fix/allow-automerge-dependabot-prs branch August 25, 2024 09:37
@christianlupus
Copy link
Collaborator Author

/backport to main-0.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants