Update link to parser method in README.md #2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 12 files 584 suites 1m 33s ⏱️ Results for commit a01d44b. ♻️ This comment has been updated with latest results. |
In the FAQ at the bottom of README.md is a Q&A about issues with the recipe parser, suggesting that viewers can work on the mehod that does the actual parsing. The link to the method is outdated. The place I started when searching for my issue with the parser was in `RecipeExtractionService.php` in the `parse()` method, so in this commit I update the outdated reference to point there. Signed-off-by: Nathaniel <[email protected]>
nathanielhourt
force-pushed
the
update-docs
branch
from
975c8ae to
a01d44b
Compare
christianlupus
approved these changes
Aug 25, 2024
Signed-off-by: Christian Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently wanted to work on the recipe parser to add support for some sites I wanted to import recipes from. When
doing so, I noticed the README.md had a very helpful link to the parser in its FAQ section, so I started by following
that; however, while the link was valid, the method referenced did no longer exist. I ended up backing out of the
file referenced in the link and looking around the nearby files, and quickly found a good place to start working on
the recipe parsing call tree.
In this PReq, I update the answer in that FAQ to point to the place I started, since the place it was referencing
previously was presumably removed in some past refactor.
Topic and Scope
Minor update to the README
Concerns/issues
None
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.