Skip to content

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 31, 2024

Topic and Scope

Closes #2228

Concerns/issues

None

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review May 31, 2024 08:27
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions
Copy link

Test Results

   12 files    584 suites   1m 32s ⏱️
  574 tests   574 ✅ 0 💤 0 ❌
2 296 runs  2 295 ✅ 1 💤 0 ❌

Results for commit bd79465.

@christianlupus christianlupus merged commit ec87648 into master May 31, 2024
@christianlupus christianlupus deleted the fix/2228-unicode-file-names branch May 31, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error downloading recipe from URL

3 participants