Skip to content

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 31, 2024

Topic and Scope

This is just a hot fix for #1077 hoping not to break many things.

Concerns/issues

As already mentioned in the issue, the real solution would be to fix the parser (#1675 #1110).

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus christianlupus marked this pull request as ready for review May 31, 2024 07:46
@github-actions
Copy link

Test Results

   12 files    584 suites   1m 32s ⏱️
  573 tests   573 ✅ 0 💤 0 ❌
2 292 runs  2 291 ✅ 1 💤 0 ❌

Results for commit d3af5ea.

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 654d47c into master May 31, 2024
@christianlupus christianlupus deleted the hotfix/1077-quot-in-json branch May 31, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants