Skip to content

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 21, 2024

Topic and Scope

Closes #1463

Concerns/issues

Is the PR potentially cause any issues that might be of interest? Any other issues to be tought of?
With a new storage backend this must be revisited.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions
Copy link

Test Results

   12 files    580 suites   1m 32s ⏱️
  567 tests   567 ✅ 0 💤 0 ❌
2 268 runs  2 267 ✅ 1 💤 0 ❌

Results for commit 95a1bab.

@christianlupus christianlupus marked this pull request as ready for review May 21, 2024 16:28
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit a7e991e into master May 21, 2024
@christianlupus christianlupus deleted the fix/1463-quick-fix-special-chars branch May 21, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can't show certain characters i.e. " \ " in recipe

3 participants