Skip to content

Fix/2318 error in browser console #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 4 commits into from
May 20, 2024
Merged

Fix/2318 error in browser console #2320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da4eac8
Handle empty suggestions correctly
christianlupus May 20, 2024
06ffa55
Replace nulled name in new recipe by empty name
christianlupus May 20, 2024
f2e8b89
Fix code styling
christianlupus May 20, 2024
13bc449
Update Changelog
christianlupus May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/current/2320-js-error-new-recipe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Fixed

- Fix JS errors in browser console while creating new recipes
2 changes: 1 addition & 1 deletion src/components/RecipeEdit.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ const initEmptyRecipe = () => {
// this.nutrition = {}
recipe.value = {
id: 0,
name: null,
Comment thread
christianlupus marked this conversation as resolved.
name: '',
description: '',
url: '',
image: '',
Expand Down
3 changes: 3 additions & 0 deletions src/composables/useSuggestionsPopup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ export default function useSuggestionsPopup(
);

const filteredSuggestionOptions = computed(() => {
if (suggestionsData.value === null) {
return [];
}
const { searchText } = suggestionsData.value;

return props.suggestionOptions.filter(
Expand Down