Add workaround by defining label outside - #2281
Merged
Merged
Conversation
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
marked this pull request as ready for review
May 1, 2024 08:02
Collaborator
Author
|
/approve |
christianlupus
enabled auto-merge
May 1, 2024 08:02
nextcloud-cookbook-bot
approved these changes
May 1, 2024
nextcloud-cookbook-bot
left a comment
nextcloud-cookbook-bot
left a comment
Collaborator
There was a problem hiding this comment.
Automatically approved by GitHub action on behalf of /approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Currently, there is a error logged in the browser when opening the recipe list:
This PR just sets
labelOutsideto true to quite the warning.Concerns/issues
This is just a workaround until the new frontend is in place.
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.