Skip to content

Update RecipeView.vue #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christianlupus merged 4 commits into from
May 31, 2024
Merged

Update RecipeView.vue #2236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4c8a82
Update RecipeView.vue
philiprenich Apr 8, 2024
b26e88d
Add changelog entry
philiprenich May 1, 2024
941c3c1
Reorder CSS to match lint style
philiprenich May 1, 2024
b3b4c08
Update Changelog
christianlupus May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/current/2236-fix-css-grid-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Fix CSS grid layout causing whitespace issues
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ Sorry for the inconvience.
[#2281](https://github.com/nextcloud/cookbook/pull/2281) @christianlupus
- Fix warning in browser console for edits
[#2287](https://github.com/nextcloud/cookbook/pull/2287) @christianlupus
- Fix CSS grid layout causing whitespace issues
[#2236](https://github.com/nextcloud/cookbook/pull/2236) @philiprenich

### Documentation

Expand Down
8 changes: 4 additions & 4 deletions src/components/RecipeView/RecipeView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,8 +1104,8 @@ main {
.content > .container {
display: grid;

grid-template-columns: 1fr 1em 2fr;
grid-template-rows: 100% 100% 100% 1fr;
gap: 1em;
grid-template-columns: 1fr 2fr;

.ingredients {
grid-column: 1/2;
Expand All @@ -1123,8 +1123,8 @@ main {
}

main {
grid-column: 3/4;
grid-row: 1/5;
grid-column: 2/3;
grid-row: 1/4;
}

@media screen and (max-width: 850px), print {
Expand Down