Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 2, 2024

Bumps nextcloud/coding-standard from 1.1.1 to 1.2.1.

Release notes

Sourced from nextcloud/coding-standard's releases.

v1.2.1

1.2.1 - 2024-02-01

Fix

Full Changelog: nextcloud/coding-standard@v1.2.0...v1.2.1

v1.2.0

1.2.0 - 2024-02-01

Added

  • array_syntax: Force short syntax for array
  • list_syntax: Same for list
  • fully_qualified_strict_types: Remove namespace from classname when there is a use statement, and add missing backslash for global namespace
  • no_leading_import_slash: Remove leading slash from use statement
  • nullable_type_declaration_for_default_null_value: Add missing ? on type declaration for parameters defaulting to null. This will most likely be needed to avoid warnings in PHP 8.4.
  • yoda_style: forbid yoda style comparision. This replaces null === $a by $a === null.

What's Changed

Full Changelog: nextcloud/coding-standard@v1.1.1...v1.2.0

Changelog

Sourced from nextcloud/coding-standard's changelog.

1.2.1 - 2024-02-01

Fix

1.2.0 - 2024-02-01

Added

  • array_syntax: Force short syntax for array
  • list_syntax: Same for list
  • fully_qualified_strict_types: Remove namespace from classname when there is a use statement, and add missing backslash for global namespace - Removed in 1.2.1 due to issues
  • no_leading_import_slash: Remove leading slash from use statement
  • nullable_type_declaration_for_default_null_value: Add missing ? on type declaration for parameters defaulting to null. This will most likely be needed to avoid warnings in PHP 8.4.
  • yoda_style: forbid yoda style comparision. This replaces null === $a by $a === null.
Commits
  • cf5f18d Merge pull request #16 from nextcloud/nickvergessen-patch-1
  • 35fd40e fix(docs): Update old file name in readme
  • 51cf509 fix: Remove fully_qualified_strict_types again
  • 424cdd9 Merge pull request #15 from nextcloud/enh/extend-coding-standard
  • c178f60 chore: Add missing entries to changelog
  • a60ff69 enh: Force short syntax for list as well
  • 7180117 enh: Remove leading slash in use statements
  • 2fce407 enh: Remove namespace from class FQDN if there is a use statement
  • 1dedda4 enh: Set type as nullable when default value is null (needed for PHP 8.4)
  • d9cd7a3 enh: Forbid yoda style comparison
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @nextcloud-cookbook-bot.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.1.1 to 1.2.1.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](nextcloud/coding-standard@v1.1.1...v1.2.1)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Feb 2, 2024
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 2, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@codecov
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46a9bb6) 80.07% compared to head (446cc80) 80.07%.
Report is 22 commits behind head on master.

❗ Current head 446cc80 differs from pull request most recent head 9b2f509. Consider uploading reports for the commit 9b2f509 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2122   +/-   ##
=======================================
  Coverage   80.07%   80.07%           
=======================================
  Files          92       92           
  Lines        2650     2650           
=======================================
  Hits         2122     2122           
  Misses        528      528           
Flag Coverage Δ
integration 21.43% <33.33%> (ø)
migration 5.69% <0.00%> (ø)
unittests 57.09% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...Controller/Implementation/RecipeImplementation.php 100.00% <100.00%> (ø)
lib/Helper/Filter/JSON/FixToolsFilter.php 96.29% <100.00%> (ø)
lib/Service/JsonService.php 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Feb 2, 2024

Test Results

   12 files    572 suites   1m 31s ⏱️
  552 tests   552 ✅ 0 💤 0 ❌
2 208 runs  2 207 ✅ 1 💤 0 ❌

Results for commit 446cc80.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit 64b8a1e into master Feb 13, 2024
@christianlupus christianlupus deleted the dependabot/composer/nextcloud/coding-standard-1.2.1 branch February 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants